From 10bad65fa1098bffa708225c5987db25fb64d300 Mon Sep 17 00:00:00 2001
From: Tim Windelschmidt <fionera@fionera.de>
Date: Mon, 18 Jul 2016 19:50:43 +0200
Subject: [PATCH] Added some missing issets

---
 asciitrash.php | 64 +++++++++++++++++++++++----------------------
 bintrash.php   | 70 ++++++++++++++++++++++++++------------------------
 2 files changed, 69 insertions(+), 65 deletions(-)

diff --git a/asciitrash.php b/asciitrash.php
index b12ab53..25c280e 100644
--- a/asciitrash.php
+++ b/asciitrash.php
@@ -3,43 +3,45 @@
   require("include/config.inc.php"); 
   require("include/cleanup.inc.php"); 
   include("geshi.php");
-  
-  if($_POST['action'] == "upload") {
-    if($_POST['textar'] != "") {
 
-      switch($_POST['validity']) {
-        case 1: $expire = time() + 30 * 60; break;
-        case 2: $expire = time() + 60 * 60; break;
-        case 3: $expire = time() + 12 * 60 * 60; break;
-        case 4: $expire = time() + 24 * 60 * 60; break;
-        case 5: $expire = time() + 7 * 24 * 60 * 60; break;
-        case 6: $expire = time() + 31 * 24 * 60 * 60; break;
-        case 7: $expire = time() + 3 * 31 * 24 * 60 * 60; break;
-        case 8: $expire = time() + 6 * 31 * 24 * 60 * 60; break;
-        case 9: $expire = time() + 12 * 31 * 24 * 60 * 60; break;
-      }
+if(isset($_POST['action'])) {
+    if($_POST['action'] == "upload") {
+        if($_POST['textar'] != "") {
 
-      // eine id erstellen
-      $file_id = mkhash();
-      $pub = 0;
-      if($_POST['pub']=="1") $pub = 1;
+            switch($_POST['validity']) {
+                case 1: $expire = time() + 30 * 60; break;
+                case 2: $expire = time() + 60 * 60; break;
+                case 3: $expire = time() + 12 * 60 * 60; break;
+                case 4: $expire = time() + 24 * 60 * 60; break;
+                case 5: $expire = time() + 7 * 24 * 60 * 60; break;
+                case 6: $expire = time() + 31 * 24 * 60 * 60; break;
+                case 7: $expire = time() + 3 * 31 * 24 * 60 * 60; break;
+                case 8: $expire = time() + 6 * 31 * 24 * 60 * 60; break;
+                case 9: $expire = time() + 12 * 31 * 24 * 60 * 60; break;
+            }
 
-      // eigabe entschaerfen
-      $safe_string = $db->escape($_POST['textar']);
-      $safe_synt = $db->escape($_POST['synt']);
-      
-      $db->query("INSERT INTO pastebin (pid,timest,expire,payload,syntax,pub) VALUES
+            // eine id erstellen
+            $file_id = mkhash();
+            $pub = 0;
+            if($_POST['pub']=="1") $pub = 1;
+
+            // eigabe entschaerfen
+            $safe_string = $db->escape($_POST['textar']);
+            $safe_synt = $db->escape($_POST['synt']);
+
+            $db->query("INSERT INTO pastebin (pid,timest,expire,payload,syntax,pub) VALUES
             ('{$file_id}','".time()."','{$expire}','{$safe_string}','{$safe_synt}',
              '{$pub}')");
-        
-        
-      header("Location: {$_SERVER['PHP_SELF']}?fileid=".$file_id);
-      
+
+
+            header("Location: {$_SERVER['PHP_SELF']}?fileid=".$file_id);
+
+        }
+        else {
+            header("Location: {$_SERVER['PHP_SELF']}?code=2");
+        }
     }
-    else {
-      header("Location: {$_SERVER['PHP_SELF']}?code=2");
-    }
-  }
+}
   else if(isset($_GET['fileid'])) {
     include("include/header.php");
     
diff --git a/bintrash.php b/bintrash.php
index f6b10fe..07c8449 100644
--- a/bintrash.php
+++ b/bintrash.php
@@ -2,64 +2,64 @@
   $BASE_DIR = "";
   require("include/config.inc.php"); 
   require("include/cleanup.inc.php"); 
-  
-  if($_POST['action'] == "upload") {
-    if($_FILES['upfile']['size'] > 0) {
 
-      switch($_POST['validity']) {
+if(isset($_POST['action'])) {
+  if ($_POST['action'] == "upload") {
+    if ($_FILES['upfile']['size'] > 0) {
+
+      switch ($_POST['validity']) {
         case 1:
           $expire = time() + 30 * 60;
-            break;
+          break;
         case 2:
           $expire = time() + 60 * 60;
-              break;
+          break;
         case 3:
           $expire = time() + 12 * 60 * 60;
-              break;
+          break;
         case 4:
           $expire = time() + 24 * 60 * 60;
-              break;
+          break;
         case 5:
           $expire = time() + 7 * 24 * 60 * 60;
-              break;
+          break;
         case 6:
           $expire = time() + 31 * 24 * 60 * 60;
-              break;
+          break;
         case 7:
           $expire = time() + 3 * 31 * 24 * 60 * 60;
-              break;
+          break;
         case 8:
           $expire = time() + 6 * 31 * 24 * 60 * 60;
-              break;
+          break;
         case 9:
           $expire = time() + 12 * 31 * 24 * 60 * 60;
-              break;
+          break;
       }
       // eine id erstellen
       $file_id = mkhash();
-      
-      // einen eindeutigen dateinamen erstellen
-      $file_localname = md5( $_FILES['upfile']['name'] + time());
 
-      if(move_uploaded_file($_FILES['upfile']['tmp_name'], $uploaddir . $file_localname )) {
+      // einen eindeutigen dateinamen erstellen
+      $file_localname = md5($_FILES['upfile']['name'] + time());
+
+      if (move_uploaded_file($_FILES['upfile']['tmp_name'], $uploaddir . $file_localname)) {
         $db->query("INSERT INTO files
                             (pid,timest,expire,file,name,mime,size) VALUES
-            ('{$file_id}','".time()."','{$expire}','{$file_localname}',
+            ('{$file_id}','" . time() . "','{$expire}','{$file_localname}',
              '{$_FILES['upfile']['name']}','{$_FILES['upfile']['type']}','{$_FILES['upfile']['size']}')");
-        
-        
-        chmod($uploaddir.$file_localname,0777);
-        header("Location: {$_SERVER['PHP_SELF']}?fileid=".$file_id);
-      }
-      else {
+
+
+        chmod($uploaddir . $file_localname, 0777);
+        header("Location: {$_SERVER['PHP_SELF']}?fileid=" . $file_id);
+      } else {
         header("Location: {$_SERVER['PHP_SELF']}?code=1");
       }
-    }
-    else {
+    } else {
       print_r($_FILES);
       header("Location: {$_SERVER['PHP_SELF']}?code=2");
     }
   }
+}
   else if(isset($_GET['fileid'])) {
     header("X-Trash-File: " . $base_url ."b/{$_GET['fileid']}");
     include("include/header.php");
@@ -114,19 +114,21 @@
   }
   else {
     include("include/header.php");
-    switch($_GET['code']) {
-      case "1":
-        echo "<p>Datei konnte nicht Kopiert werden!</p>";
-        break;
-      case "2":
-        echo "<p>Keine Datei angegeben oder Datei zu gross!</p>";
-        break;
+    if (isset($_GET['code'])) {
+      switch($_GET['code']) {
+        case "1":
+          echo "<p>Datei konnte nicht Kopiert werden!</p>";
+          break;
+        case "2":
+          echo "<p>Keine Datei angegeben oder Datei zu gross!</p>";
+          break;
+      }
     }
     ?>
     <form name="ul" action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post" enctype="multipart/form-data"
           onsubmit="document.ul.u.value='Bitte warten ...';document.ul.u.disabled=true" >
       <input type="hidden" name="action" value="upload" />
-      Dateien bis max. <?php echo ini_get(post_max_size); ?>:<br/>
+      Dateien bis max. <?php echo ini_get('post_max_size'); ?>:<br/>
       <input type="file" name="upfile" /><br /><br />
       G&uuml;ltigkeit:
       <select name="validity" size="1">